Nico Boehr <nrb@xxxxxxxxxxxxx> writes: > Hi Marc, Nina, > > Quoting Marc Hartmayer (2023-03-07 10:10:50) >> Define and use a macro for the stack frame size. While at it, fix >> whitespace in the `gs_handler_asm` block. >> >> Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxx> >> Co-developed-by: Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx> > > this commit breaks cross-compilation on x86 for me. > > Steps to reproduce: > > $ mkdir build > $ cd build > $ ../configure --arch=s390x --cross-prefix=s390x-linux-gnu- > $ make -j16 > > Error is: > In file included from /builds/Nico-Boehr/kvm-unit-tests/lib/s390x/interrupt.c:12: > /builds/Nico-Boehr/kvm-unit-tests/lib/s390x/asm/asm-offsets.h:8:10: fatal error: generated/asm-offsets.h: No such file or directory > 8 | #include <generated/asm-offsets.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > compilation terminated. > make: *** [<builtin>: lib/s390x/interrupt.o] Error 1 > make: *** Waiting for unfinished jobs.... > > Can you take care of this? It prevents me from sending the next pull > request. Thanks for reporting this. Commit 6ef5785d30e8 ("s390x/Makefile: refactor CPPFLAGS") broke it. I will be sending a fix for this soon. -- Kind regards / Beste Grüße Marc Hartmayer IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Gregor Pillen Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294