On Thu, Mar 30, 2023 at 05:05:31PM -0600, Alex Williamson wrote: > > I suggest to check for VFIO_PCI_HOT_RESET_FLAG_IOMMUFD_DEV_ID on input > > as well. I know the old kernels don't enforce this but at least we > > could start enforcing it going forward so that the group path would > > reject it to catch userspace bugs. > > > > May as well fix it up to fully validate the flags > > Is this under the guise of "if nobody complains it's ok, otherwise > revert" plan? Yah, assuming people don't pass in uninited structs. Jason