Re: [PATCH-for-8.0 v2 1/3] softmmu: Restrict cpu_check_watchpoint / address_matches to TCG accel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH-for-8.0 v2 1/3] softmmu: Restrict cpu_check_watchpoint / address_matches to TCG accel
From: Fabiano Rosas <farosas@xxxxxxx>
Date: Wed, 29 Mar 2023 10:57:06 -0300
Cc: Halil Pasic <pasic@xxxxxxxxxxxxx>, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>, Daniel Henrique Barboza <danielhb413@xxxxxxxxx>, qemu-ppc@xxxxxxxxxx, Yanan Wang <wangyanan55@xxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Greg Kurz <groug@xxxxxxxx>, kvm@xxxxxxxxxxxxxxx, Ilya Leoshkevich <iii@xxxxxxxxxxxxx>, Peter Maydell <peter.maydell@xxxxxxxxxx>, Alex Bennée <alex.bennee@xxxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, qemu-s390x@xxxxxxxxxx, qemu-arm@xxxxxxxxxx, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Cédric Le Goater <clg@xxxxxxxx>
In-reply-to: <20230328173117.15226-2-philmd@linaro.org>
References: <20230328173117.15226-1-philmd@linaro.org> <20230328173117.15226-2-philmd@linaro.org>

Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> writes:

> Both cpu_check_watchpoint() and cpu_watchpoint_address_matches()
> are specific to TCG system emulation. Declare them in "tcg-cpu-ops.h"
> to be sure accessing them from non-TCG code is a compilation error.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>

Reviewed-by: Fabiano Rosas <farosas@xxxxxxx>

References:
- [PATCH-for-8.0 v2 0/3] softmmu: Restore use of CPU watchpoint for non-TCG accelerators
  - From: Philippe Mathieu-Daudé
- [PATCH-for-8.0 v2 1/3] softmmu: Restrict cpu_check_watchpoint / address_matches to TCG accel
  - From: Philippe Mathieu-Daudé

Prev by Date: [GIT PULL 1/1] KVM: s390: pv: fix external interruption loop not always detected
Next by Date: Re: [PATCH-for-8.0 v2 2/3] softmmu/watchpoint: Add missing 'qemu/error-report.h' include
Previous by thread: [PATCH-for-8.0 v2 1/3] softmmu: Restrict cpu_check_watchpoint / address_matches to TCG accel
Next by thread: [PATCH-for-8.0 v2 2/3] softmmu/watchpoint: Add missing 'qemu/error-report.h' include
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]