On Thu, Mar 23, 2023 at 3:28 PM David Matlack <dmatlack@xxxxxxxxxx> wrote: > > On Mon, Mar 06, 2023 at 02:41:23PM -0800, Vipin Sharma wrote: > > Set __GFP_ZERO to gfp_zero in default initizliation of struct > > kvm_mmu_memory_cache{} > > > > All of the users of default initialization code of struct > > kvm_mmu_memory_cache{} explicitly sets gfp_zero to __GFP_ZERO. This can > > be moved to common initialization logic. > > If that were true we could get rid of gfp_zero entirely and hard-code > __GFP_ZERO in the memory allocator! mmu_shadowed_info_cache is the one > that does not set __GFP_ZERO. > Can we use __GFP_ZERO for mmu_shadowed_info_cache? Also, MIPS doesn't use __GFP_ZERO, I think it might be a missed thing in MIPS rather than intentional.