Re: [kvm-unit-tests PATCH 6/8] s390x: uv-host: Fix create guest variable storage prefix check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Janosch Frank (2023-03-23 11:39:11)
> We want more than one cpu and the rc is 10B, not 109.
                                                     ^
Code says 10e        --------------------------------|

> 
> Signed-off-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
> ---
>  s390x/uv-host.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/s390x/uv-host.c b/s390x/uv-host.c
> index 42ea2a53..d92571b5 100644
> --- a/s390x/uv-host.c
> +++ b/s390x/uv-host.c
> @@ -434,11 +434,15 @@ static void test_config_create(void)
>                "base storage origin contains lowcore");
>         uvcb_cgc.conf_base_stor_origin = tmp;
>  
> -       if (smp_query_num_cpus() == 1) {
> +       /*
> +        * Let's not make it too easy and use a second cpu to set a
> +        * non-zero prefix.
> +        */
> +       if (smp_query_num_cpus() > 1) {
>                 sigp_retry(1, SIGP_SET_PREFIX,
>                            uvcb_cgc.conf_var_stor_origin + PAGE_SIZE, NULL);

While at it, this should be smp_sigp, no?

With the commit message fixup:

Reviewed-by: Nico Boehr <nrb@xxxxxxxxxxxxx>




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux