Re: [PATCH 4/4] KVM: x86: Change return type of is_long_mode() to bool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2023-03-22 at 12:58 +0800, Binbin Wu wrote:
> Change return type of is_long_mode() to bool to avoid implicit cast.
> 
> Signed-off-by: Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx>
> ---
>  arch/x86/kvm/x86.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h
> index 577b82358529..203fb6640b5b 100644
> --- a/arch/x86/kvm/x86.h
> +++ b/arch/x86/kvm/x86.h
> @@ -126,12 +126,12 @@ static inline bool is_protmode(struct kvm_vcpu *vcpu)
>  	return kvm_is_cr0_bit_set(vcpu, X86_CR0_PE);
>  }
>  
> -static inline int is_long_mode(struct kvm_vcpu *vcpu)
> +static inline bool is_long_mode(struct kvm_vcpu *vcpu)
>  {
>  #ifdef CONFIG_X86_64
> -	return vcpu->arch.efer & EFER_LMA;
> +	return !!(vcpu->arch.efer & EFER_LMA);
>  #else
> -	return 0;
> +	return false;
>  #endif
>  }
>  

Reviewed-by: Kai Huang <kai.huang@xxxxxxxxx>




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux