On Mon, Mar 15, 2010 at 09:44:26AM +0200, Avi Kivity wrote: > On 03/14/2010 08:06 PM, Gleb Natapov wrote: > >>Suggest simply reentering every N executions. > >> > >This restart mechanism is, in fact, needed for ins read ahead to work. > >After reading ahead from IO port we need to avoid entering decoder > >until entire cache is consumed otherwise decoder will clear cache and > >data will be lost. So we can't just enter guest in arbitrary times, only > >when read ahead cache is empty. Since read ahead is never done across > >page boundary this is save place to re-enter guest. > > Please make the two depend on each other directly then. We can't > expect the reader of the emulator code know that. > We can document that. I wouldn't want to have different conditions for guest re-entry for different opcodes. > Have the emulator ask the buffer when it is empty. > It will be always empty for all string ops except INS. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
