On Tue, Mar 21, 2023 at 04:02:21PM +0100, Andrew Jones wrote: ... > > + > > +# TLB Torture Tests > > +[tlbflush-code::all_other] > > It's better to use '-', '_', '.', or ',' than '::' because otherwise the > standalone test will have a filename like tests/tlbflush-code::all_other > which will be awkward for shells. > > BTW, have you tried running these tests as standalone? Since they're > 'nodefault' it'd be good if they work that way. > > > +file = tlbflush-code.flat > > +smp = $(($MAX_SMP>4?4:$MAX_SMP)) > > +groups = nodefault mttcg > > + > > +[tlbflush-code::page_other] > > +file = tlbflush-code.flat > > +smp = $(($MAX_SMP>4?4:$MAX_SMP)) > > +extra_params = -append 'page' > > +groups = nodefault mttcg > > + > > +[tlbflush-code::all_self] > > +file = tlbflush-code.flat > > +smp = $(($MAX_SMP>4?4:$MAX_SMP)) > > +extra_params = -append 'self' > > +groups = nodefault mttcg > > + > > +[tlbflush-code::page_self] > > +file = tlbflush-code.flat > > +smp = $(($MAX_SMP>4?4:$MAX_SMP)) > > +extra_params = -append 'page self' > > +groups = nodefault mttcg Shouldn't these also be in something like a "tlb" group? Thanks, drew
