Re: [PATCH v2 24/30] KVM: x86 emulator: during rep emulation decrement ECX only if emulation succeeded

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/14/2010 06:21 PM, Gleb Natapov wrote:

@@ -2943,6 +2942,9 @@ writeback:
  					 c->regs[VCPU_REGS_RDI]);
  	}

+	if (c->rep_prefix)
+		register_address_increment(c,&c->regs[VCPU_REGS_RCX], -1);
+

Should be really (c->rep_prefix && (c->d & String)). Some sse instructions accept rep prefix, as well as pause (rep; nop).

We don't emulate any of them now so breakage is only theoretical.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux