On Fri, Mar 17, 2023, Anish Moorthy wrote: > On Fri, Mar 17, 2023 at 11:27 AM Oliver Upton <oliver.upton@xxxxxxxxx> wrote: > > > > + pfn = __gfn_to_pfn_memslot( > > > + memslot, gfn, exit_on_memory_fault, false, NULL, > > > + write_fault, &writable, NULL); > > > > As stated before [*], this google3-esque style does not match the kernel style > > guide. You may want to check if your work machine is setting up a G3-specific > > editor configuration behind your back. > > > > [*] https://lore.kernel.org/kvm/Y+0QRsZ4yWyUdpnc@xxxxxxxxxx/ > > If you're referring to the indentation, then that was definitely me. The two issues are (1) don't put newlines immediately after an opening '(', and (2) align indentation relative to the direct parent '(' that encapsulates the code. Concretely, the above should be: pfn = __gfn_to_pfn_memslot(memslot, gfn, exit_on_memory_fault, false, NULL, write_fault, &writable, NULL); > I'll give the style guide another readthrough before I submit the next > version then, since checkpatch.pl doesn't seem to complain here. I don't think checkpatch looks for these particular style issues. FWIW, you really shouldn't need to read through the formal documentation for these "basic" rules, just spend time poking around the code base. If your code looks different than everything else, then you're likely doing it wrong.
