On Wed, Mar 15, 2023 at 10:42:09AM +0000, "Huang, Kai" <kai.huang@xxxxxxxxx> wrote: > On Sun, 2023-03-12 at 10:55 -0700, isaku.yamahata@xxxxxxxxx wrote: > > + > > +static inline bool is_td(struct kvm *kvm) > > +{ > > + return kvm->arch.vm_type == KVM_X86_PROTECTED_VM; > > +} > > + > > KVM_X86_PROTECTED_VM is defined in the next patch, which means this patch cannot > compile. > > Also, why KVM_X86_PROTECTED_VM == TDX VM? This part needs to be resolved. Use KVM_X86_PROTECTED_VM as TDX VM or new type KVM_X86_TDX_VM or other way to specify VM type. Given pKVM is coming, dedicated VM type seems better. I'll switch it to KVM_X86_TDX_VM next respin. -- Isaku Yamahata <isaku.yamahata@xxxxxxxxx>