Re: [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()
From: Nicolin Chen <nicolinc@xxxxxxxxxx>
Date: Wed, 15 Mar 2023 20:25:56 -0700
Cc: Jason Gunthorpe <jgg@xxxxxxxxxx>, "mjrosato@xxxxxxxxxxxxx" <mjrosato@xxxxxxxxxxxxx>, "jasowang@xxxxxxxxxx" <jasowang@xxxxxxxxxx>, "Hao, Xudong" <xudong.hao@xxxxxxxxx>, "peterx@xxxxxxxxxx" <peterx@xxxxxxxxxx>, "Xu, Terrence" <terrence.xu@xxxxxxxxx>, "chao.p.peng@xxxxxxxxxxxxxxx" <chao.p.peng@xxxxxxxxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "lulu@xxxxxxxxxx" <lulu@xxxxxxxxxx>, "joro@xxxxxxxxxx" <joro@xxxxxxxxxx>, "Zhao, Yan Y" <yan.y.zhao@xxxxxxxxx>, "intel-gfx@xxxxxxxxxxxxxxxxxxxxx" <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>, "eric.auger@xxxxxxxxxx" <eric.auger@xxxxxxxxxx>, "alex.williamson@xxxxxxxxxx" <alex.williamson@xxxxxxxxxx>, "intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx" <intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx>, "yi.y.sun@xxxxxxxxxxxxxxx" <yi.y.sun@xxxxxxxxxxxxxxx>, "cohuck@xxxxxxxxxx" <cohuck@xxxxxxxxxx>, "shameerali.kolothum.thodi@xxxxxxxxxx" <shameerali.kolothum.thodi@xxxxxxxxxx>, "suravee.suthikulpanit@xxxxxxx" <suravee.suthikulpanit@xxxxxxx>, "robin.murphy@xxxxxxx" <robin.murphy@xxxxxxx>
In-reply-to: <BL1PR11MB52710B5DCB08214EF4542D098CBC9@BL1PR11MB5271.namprd11.prod.outlook.com>
References: <20230308131340.459224-1-yi.l.liu@intel.com> <20230308131340.459224-2-yi.l.liu@intel.com> <ZAtqlnCk7uccR5E7@nvidia.com> <ZBAuXo166M+z8b3z@Asurada-Nvidia> <ZBEY49XtiFUImfe4@Asurada-Nvidia> <BN9PR11MB5276738DC59AC1B4A66AB3C38CBF9@BN9PR11MB5276.namprd11.prod.outlook.com> <ZBFmh2iAqGGb8CjK@Asurada-Nvidia> <BN9PR11MB52765D7977F987960072482E8CBF9@BN9PR11MB5276.namprd11.prod.outlook.com> <ZBGJzefTm4p/ReIu@Asurada-Nvidia> <BL1PR11MB52710B5DCB08214EF4542D098CBC9@BL1PR11MB5271.namprd11.prod.outlook.com>

On Thu, Mar 16, 2023 at 02:53:50AM +0000, Tian, Kevin wrote:

> > Please check if they look okay, so that Yi can integrate them
> > accordingly to the emulated/cdev series.
> 
> this split looks reasonable to me. Go ahead.

Thanks for the review! I will address those comments and renew
those commits by the end of the day.

Thanks
Nic

References:
- [PATCH v1 0/5] vfio: Make emulated devices prepared for vfio device cdev
  - From: Yi Liu
- [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()
  - From: Yi Liu
- Re: [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()
  - From: Jason Gunthorpe
- Re: [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()
  - From: Nicolin Chen
- Re: [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()
  - From: Nicolin Chen
- RE: [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()
  - From: Tian, Kevin
- Re: [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()
  - From: Nicolin Chen
- RE: [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()
  - From: Tian, Kevin
- Re: [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()
  - From: Nicolin Chen
- RE: [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()
  - From: Tian, Kevin

Prev by Date: [PATCH 1/2] KVM: PPC: Add kvm selftests support for powerpc
Next by Date: [offlist] RE: [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET
Previous by thread: RE: [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()
Next by thread: Re: [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()
Index(es):
- Date
- Thread

[Index of Archives] [KVM ARM] [KVM ia64] [KVM ppc] [Virtualization Tools] [Spice Development] [Libvirt] [Libvirt Users] [Linux USB Devel] [Linux Audio Users] [Yosemite Questions] [Linux Kernel] [Linux SCSI] [XFree86]