On Fri, Mar 10, 2023 at 04:22:50PM -0800, Sean Christopherson wrote: > Bury the declaration of the page-track helpers that are intended only for > internal KVM use in a "private" header. In addition to guarding against > unwanted usage of the internal-only helpers, dropping their definitions > avoids exposing other structures that should be KVM-internal, e.g. for > memslots. This is a baby step toward making kvm_host.h a KVM-internal > header in the very distant future. > > Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx> > --- > arch/x86/include/asm/kvm_page_track.h | 26 ++++----------------- > arch/x86/kvm/mmu/mmu.c | 3 ++- > arch/x86/kvm/mmu/page_track.c | 8 +------ > arch/x86/kvm/mmu/page_track.h | 33 +++++++++++++++++++++++++++ > arch/x86/kvm/x86.c | 1 + > 5 files changed, 42 insertions(+), 29 deletions(-) > create mode 100644 arch/x86/kvm/mmu/page_track.h > > diff --git a/arch/x86/include/asm/kvm_page_track.h b/arch/x86/include/asm/kvm_page_track.h > index e5eb98ca4fce..deece45936a5 100644 > --- a/arch/x86/include/asm/kvm_page_track.h > +++ b/arch/x86/include/asm/kvm_page_track.h A curious question: are arch/x86/include/asm/kvm_*.h all expected to be external accessible? Thanks Yan