Hi, On Fri, Mar 10, 2023 at 03:03:52PM +0000, Alexandru Elisei wrote: [..] > On Mon, Mar 06, 2023 at 12:03:29PM +0000, Rajnesh Kanwal wrote: [..] > > +int virtio_tranport_parser(const struct option *opt, const char *arg, int unset) > > If --virtio-transport is not specified on the kvmtool command line, then > the default transport is set to VIRTIO_PCI, because that is the first > member in the virtio_trans enum, and struct kvm is initialized to 0 in > kvm__new() when it's allocated with calloc. > > The above can be obscure for someone who is not familiar with the code. I > think making the default explicit, by setting kvm->cfg.virtio_transport = > VIRTIO_PCI in kvm_cmd_run_init(), before the command line arguments are > parsed, would be clearer. On second though, struct kvm_config relies on all the fields being set to zero by kvm__new(), so there's no need to special case virtio_transport. Thanks, Alex
