> From: Jason Gunthorpe <jgg@xxxxxxxxxx> > Sent: Wednesday, March 8, 2023 8:36 AM > > /* > - * FIXME: Hack around missing a device-centric iommu api, only > attach to > - * the group once for the first device that is in the group. > + * Only attach to the group once for the first device that is in the > + * group. All the other devices will follow this attachment. > + * The user can attach every device individually as well. > */ the last sentence is confusing. 'as well' sounds like there is another option but we don't have a group version of hwpt attach. otherwise looks good to me. Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>