On Wed, Mar 08, 2023, Robert Hoo wrote: > From: Robert Hoo <robert.hu@xxxxxxxxxxxxxxx> > > If !guest_cpuid_has(vcpu, X86_FEATURE_PCID), CR4.PCIDE would have been in > vcpu->arch.cr4_guest_rsvd_bits and failed earlier kvm_is_valid_cr4() check. > Remove this meaningless check. > > Reviewed-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx> > Signed-off-by: Robert Hoo <robert.hu@xxxxxxxxxxxxxxx> > --- Nice! I think I'll add Fixes: 4683d758f48e ("KVM: x86: Supplement __cr4_reserved_bits() with X86_FEATURE_PCID check") when applying (won't happen until next week).