On Tue, Feb 21, 2023, Sean Christopherson wrote: > On Sat, Feb 18, 2023, Mingwei Zhang wrote: > > On Fri, Feb 17, 2023, Sean Christopherson wrote: > > > +Coding Style > > > +~~~~~~~~~~~~ > > > +When it comes to style, naming, patterns, etc., consistency is the number one > > > +priority in KVM x86. If all else fails, match what already exists. > > > + > > > +With a few caveats listed below, follow the tip tree maintainers' preferred > > > +:ref:`maintainer-tip-coding-style`, as patches/series often touch both KVM and > > > +non-KVM x86 files, i.e. draw the attention of KVM *and* tip tree maintainers. > > > + > > > +Using reverse fir tree for variable declarations isn't strictly required, > > > +though it is still preferred. > > > > What is the 'reverse fir tree'? Maybe, "Reverse Christmas Tree" is > > better to understand. > > For some parts of the world, but not all. For this, I want to follow whatever > description the tip tree uses, which as of today is "reverse fir tree", as this > is really a qualifier on the tip tree rules. Some parts of the world is correct. In fact, in our world, we use 'reverse Christmas Tree' more than the other. Check lore.kernel.org: https://lore.kernel.org/all/?q=reverse+christmas+tree https://lore.kernel.org/all/?q=reverse+fir+tree You will find the former is used 10x more frequent than the latter. Overall, I don't hold a strong opinion immediately after I understand the meaning of 'reverse fir tree' and I do agree that it is safer to follow the Linux Tip Tree Handbook. Also, thanks for the whole guideline. -Mingwei
