On Thursday, March 2, 2023 3:47 AM, David Matlack wrote: > On Wed, Mar 1, 2023 at 5:38 AM Wei Wang <wei.w.wang@xxxxxxxxx> wrote: > > > > Current KVM_BUG and KVM_BUG_ON assumes that 'cond' passed from > callers > > is 32-bit as it casts 'cond' to the type of int. This will be wrong if 'cond' > > provided by a caller is 64-bit, e.g. an error code of > > 0xc0000d0300000000 will be converted to 0, which is not expected. > > Improves the implementation by using !!(cond) in KVM_BUG and > > KVM_BUG_ON. Compared to changing 'int' to 'int64_t', this has less LOCs. > > Less LOC is nice to have, but please preserve the behavior that "cond" > is evaluated only once by KVM_BUG() and KVM_BUG_ON(). i.e. > KVM_BUG_ON(do_something(), kvm) should only result in a single call to > do_something(). Good point, thanks! Using 'typeof(cond)' looks like a better choice.
