Re: [PATCH 1/2] lib/test_bitmap: increment failure counter properly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 27, 2023 at 01:45:23PM -0800, Yury Norov wrote:
> The tests that don't use expect_eq() macro to determine that a test is
> failured must increment failed_tests explicitly.

...

>  			pr_err("bitmap_copy_arr32(nbits == %d:"
>  				" tail is not safely cleared: %d\n",

Usually we don't split string literals (since checkpatch doesn't complain on a
looong lines with them at the end of the line),

...

>  			pr_err("bitmap_copy_arr64(nbits == %d:"
>  				" tail is not safely cleared: %d\n", nbits, next_bit);

Ditto.

P.S. Seems a material for another patch.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux