Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx> writes: > CpuS390Entitlement would be useful in both machine.json and machine-target.json > because query-cpu-fast is defined in machine.json and set-cpu-topology is defined > in machine-target.json. > So then the question is where best to define CpuS390Entitlement. > In machine.json and include machine.json in machine-target.json? > Or define it in another file and include it from both? Either should work. If you include machine.json into machine-target.json, the qapi-FOO-machine-target.h will include the qapi-FOO-machine.h. No big deal, I think: affects just eight .c.