On Fri, 24 Feb 2023 20:08:15 +0000, Colton Lewis <coltonlewis@xxxxxxxxxx> wrote: > > I hope someone else looks at this one because I don't understand NV. Don't worry, you're not alone. > Marc Zyngier <maz@xxxxxxxxxx> writes: > > > + struct arch_timer_context *ctx; > > + > > + ctx = (vcpu_has_nv(vcpu) && is_hyp_ctxt(vcpu)) ? vcpu_hvtimer(vcpu) > > + : vcpu_vtimer(vcpu); > > I don't think that ternary is the easiest to read and would prefer an if > statement. As the saying goes, there is no accounting for taste. Do you see a technical issue with this statement? M. -- Without deviation from the norm, progress is not possible.