Re: [kvm-unit-tests PATCH v2 1/3] s390x/spec_ex: Use PSW macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/21/23 18:48, Nina Schoetterl-Glausch wrote:
Replace explicit psw definition by PSW macro.
No functional change intended.

Signed-off-by: Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx>
---
  s390x/spec_ex.c | 10 ++--------
  1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/s390x/spec_ex.c b/s390x/spec_ex.c
index 42ecaed3..2adc5996 100644
--- a/s390x/spec_ex.c
+++ b/s390x/spec_ex.c
@@ -105,10 +105,7 @@ static int check_invalid_psw(void)
  /* For normal PSWs bit 12 has to be 0 to be a valid PSW*/
  static int psw_bit_12_is_1(void)
  {
-	struct psw invalid = {
-		.mask = BIT(63 - 12),
-		.addr = 0x00000000deadbeee
-	};
+	struct psw invalid = PSW(BIT(63 - 12), 0x00000000deadbeee);

I think we've passed the point where we can use a constant for the short psw. But we can convert that at a later time, I'll add it to the TODO list, so:

Reviewed-by: Janosch Frank <frankja@xxxxxxxxxxxxx>



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux