On Wed, Feb 15, 2023 at 9:24 AM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> On Wed, Feb 15, 2023, Anish Moorthy wrote:
> > + if (mem_fault_nowait) {
> > + if (fault->pfn == KVM_PFN_ERR_FAULT) {
> > + vcpu->run->exit_reason = KVM_EXIT_MEMORY_FAULT;
> > + vcpu->run->memory_fault.gpa = fault->gfn << PAGE_SHIFT;
> > + vcpu->run->memory_fault.size = PAGE_SIZE;
>
> This belongs in a separate patch, and the exit stuff should be filled in by
> kvm_handle_error_pfn(). Then this if-statement goes away entirely because the
> "if (!async)" will always evaluate true in the nowait case.
Hi Sean, what exactly did you want "in a separate patch"? Unless you
mean separating
the changes to arch/x86/kvm/mmu/mmu.c and the one-liner to enable the cap in
arch/x86/kvm/x86.c, I don't really understand how this patch could
logically be split.
