Hi Tianrui, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v6.2] [cannot apply to kvm/queue kvm/linux-next next-20230220] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Tianrui-Zhao/LoongArch-KVM-Add-kvm-related-header-files/20230220-151305 patch link: https://lore.kernel.org/r/20230220065735.1282809-30-zhaotianrui%40loongson.cn patch subject: [PATCH v2 29/29] LoongArch: KVM: Enable kvm config and add the makefile config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20230220/202302201710.ERtpPSuD-lkp@xxxxxxxxx/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/55ee4e26440ad32966cf3ee796b8a519c77ac66b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Tianrui-Zhao/LoongArch-KVM-Add-kvm-related-header-files/20230220-151305 git checkout 55ee4e26440ad32966cf3ee796b8a519c77ac66b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash arch/loongarch/kvm/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202302201710.ERtpPSuD-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): arch/loongarch/kvm/vcpu.c: In function 'kvm_own_fpu': >> arch/loongarch/kvm/vcpu.c:595:23: warning: variable 'sr' set but not used [-Wunused-but-set-variable] 595 | unsigned long sr; | ^~ arch/loongarch/kvm/vcpu.c: At top level: >> arch/loongarch/kvm/vcpu.c:636:5: warning: no previous prototype for 'kvm_vcpu_ioctl_interrupt' [-Wmissing-prototypes] 636 | int kvm_vcpu_ioctl_interrupt(struct kvm_vcpu *vcpu, | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from include/linux/huge_mm.h:8, from include/linux/mm.h:746, from include/linux/kvm_host.h:16, from arch/loongarch/kvm/vcpu.c:6: arch/loongarch/kvm/vcpu.c:126:25: warning: 'vcpu_pid_fops' defined but not used [-Wunused-const-variable=] 126 | DEFINE_SIMPLE_ATTRIBUTE(vcpu_pid_fops, vcpu_pid_get, NULL, "%llu\n"); | ^~~~~~~~~~~~~ include/linux/fs.h:3496:37: note: in definition of macro 'DEFINE_SIMPLE_ATTRIBUTE_XSIGNED' 3496 | static const struct file_operations __fops = { \ | ^~~~~~ arch/loongarch/kvm/vcpu.c:126:1: note: in expansion of macro 'DEFINE_SIMPLE_ATTRIBUTE' 126 | DEFINE_SIMPLE_ATTRIBUTE(vcpu_pid_fops, vcpu_pid_get, NULL, "%llu\n"); | ^~~~~~~~~~~~~~~~~~~~~~~ arch/loongarch/kvm/vcpu.c:116:25: warning: 'lvcpu_stat_fops' defined but not used [-Wunused-const-variable=] 116 | DEFINE_SIMPLE_ATTRIBUTE(lvcpu_stat_fops, lvcpu_stat_get, NULL, "%llu\n"); | ^~~~~~~~~~~~~~~ include/linux/fs.h:3496:37: note: in definition of macro 'DEFINE_SIMPLE_ATTRIBUTE_XSIGNED' 3496 | static const struct file_operations __fops = { \ | ^~~~~~ arch/loongarch/kvm/vcpu.c:116:1: note: in expansion of macro 'DEFINE_SIMPLE_ATTRIBUTE' 116 | DEFINE_SIMPLE_ATTRIBUTE(lvcpu_stat_fops, lvcpu_stat_get, NULL, "%llu\n"); | ^~~~~~~~~~~~~~~~~~~~~~~ vim +/sr +595 arch/loongarch/kvm/vcpu.c 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 591 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 592 /* Enable FPU for guest and restore context */ 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 593 void kvm_own_fpu(struct kvm_vcpu *vcpu) 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 594 { 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 @595 unsigned long sr; 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 596 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 597 preempt_disable(); 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 598 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 599 sr = kvm_read_hw_gcsr(LOONGARCH_CSR_EUEN); 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 600 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 601 /* 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 602 * Enable FPU for guest 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 603 * We set FR and FRE according to guest context 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 604 */ 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 605 set_csr_euen(CSR_EUEN_FPEN); 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 606 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 607 /* If guest FPU state not active, restore it now */ 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 608 if (!(vcpu->arch.aux_inuse & KVM_LARCH_FPU)) { 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 609 kvm_restore_fpu(&vcpu->arch.fpu); 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 610 vcpu->arch.aux_inuse |= KVM_LARCH_FPU; 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 611 trace_kvm_aux(vcpu, KVM_TRACE_AUX_RESTORE, KVM_TRACE_AUX_FPU); 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 612 } else { 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 613 trace_kvm_aux(vcpu, KVM_TRACE_AUX_ENABLE, KVM_TRACE_AUX_FPU); 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 614 } 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 615 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 616 preempt_enable(); 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 617 } 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 618 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 619 /* Save and disable FPU */ 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 620 void kvm_lose_fpu(struct kvm_vcpu *vcpu) 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 621 { 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 622 preempt_disable(); 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 623 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 624 if (vcpu->arch.aux_inuse & KVM_LARCH_FPU) { 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 625 kvm_save_fpu(&vcpu->arch.fpu); 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 626 vcpu->arch.aux_inuse &= ~KVM_LARCH_FPU; 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 627 trace_kvm_aux(vcpu, KVM_TRACE_AUX_SAVE, KVM_TRACE_AUX_FPU); 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 628 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 629 /* Disable FPU */ 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 630 clear_csr_euen(CSR_EUEN_FPEN); 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 631 } 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 632 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 633 preempt_enable(); 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 634 } 81d0b9f4fa1f11 Tianrui Zhao 2023-02-20 635 a4dadfc6695b38 Tianrui Zhao 2023-02-20 @636 int kvm_vcpu_ioctl_interrupt(struct kvm_vcpu *vcpu, a4dadfc6695b38 Tianrui Zhao 2023-02-20 637 struct kvm_loongarch_interrupt *irq) a4dadfc6695b38 Tianrui Zhao 2023-02-20 638 { a4dadfc6695b38 Tianrui Zhao 2023-02-20 639 int intr = (int)irq->irq; a4dadfc6695b38 Tianrui Zhao 2023-02-20 640 struct kvm_vcpu *dvcpu = NULL; a4dadfc6695b38 Tianrui Zhao 2023-02-20 641 a4dadfc6695b38 Tianrui Zhao 2023-02-20 642 if (irq->cpu == -1) a4dadfc6695b38 Tianrui Zhao 2023-02-20 643 dvcpu = vcpu; a4dadfc6695b38 Tianrui Zhao 2023-02-20 644 else a4dadfc6695b38 Tianrui Zhao 2023-02-20 645 dvcpu = kvm_get_vcpu(vcpu->kvm, irq->cpu); a4dadfc6695b38 Tianrui Zhao 2023-02-20 646 a4dadfc6695b38 Tianrui Zhao 2023-02-20 647 if (intr > 0) a4dadfc6695b38 Tianrui Zhao 2023-02-20 648 _kvm_queue_irq(dvcpu, intr); a4dadfc6695b38 Tianrui Zhao 2023-02-20 649 else if (intr < 0) a4dadfc6695b38 Tianrui Zhao 2023-02-20 650 _kvm_dequeue_irq(dvcpu, -intr); a4dadfc6695b38 Tianrui Zhao 2023-02-20 651 else { a4dadfc6695b38 Tianrui Zhao 2023-02-20 652 kvm_err("%s: invalid interrupt ioctl (%d:%d)\n", __func__, a4dadfc6695b38 Tianrui Zhao 2023-02-20 653 irq->cpu, irq->irq); a4dadfc6695b38 Tianrui Zhao 2023-02-20 654 return -EINVAL; a4dadfc6695b38 Tianrui Zhao 2023-02-20 655 } a4dadfc6695b38 Tianrui Zhao 2023-02-20 656 a4dadfc6695b38 Tianrui Zhao 2023-02-20 657 kvm_vcpu_kick(dvcpu); a4dadfc6695b38 Tianrui Zhao 2023-02-20 658 return 0; a4dadfc6695b38 Tianrui Zhao 2023-02-20 659 } a4dadfc6695b38 Tianrui Zhao 2023-02-20 660 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
