Re: [PATCH] selftests/kvm: Fix bug in how demand_paging_test calculates paging rate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 16, 2023, Oliver Upton wrote:
> The shortlog doesn't give any hint as to what the bug actually is.
> Maybe:
> 
>   KVM: selftests: Fix nsec to sec conversion in demand_paging_test

+1

> On Thu, Feb 16, 2023 at 08:02:18PM +0000, Anish Moorthy wrote:
> > The current denominator is 1E8, not 1E9 as it should be.
> 
>   demand_paging_test uses 1E8 as the denominator to convert nanoseconds
>   to seconds, which is wrong. Use NSEC_PER_SEC instead to fix the issue
>   and make the conversion obvious.
> 
> > Reported-by: James Houghton <jthoughton@xxxxxxxxxx>
> > Signed-off-by: Anish Moorthy <amoorthy@xxxxxxxxxx>
> 
> Bikeshedding aside:
> 
> Reviewed-by: Oliver Upton <oliver.upton@xxxxxxxxx>

With Oliver's shortlog (I'm indifferent on the changelog),

Reviewed-by: Sean Christopherson <seanjc@xxxxxxxxxx>



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux