On Wed, Feb 15, 2023, David Matlack wrote: > On Wed, Feb 15, 2023 at 4:44 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote: > > > > On Mon, Feb 13, 2023, David Matlack wrote: > > > Make @tdp_mmu_allowed static since it is only ever used within > > > > Doesn't "@" usually refer to function parameters? > > Oh is that the convention? For some reason I assumed it was used when > referring to any variable. Yes? My experience with it is entirely in the context of kernel-doc syntax, where it's used to document function params and struct field. Global symbols don't need additional reference because they are the focus of the comment/documentation.