On Thu, Feb 16, 2023 at 10:28:33AM +0000, Liu, Yi L wrote: > However, I need to admit, your fix can reduce the reference of iommufd file. > This may avoid file reference counting overflow if there are multiple devices > assigned to an application. I'm not sure how possible it is though. 😊 I'll see > if Alex or Jason have any preference. Please write refcounting in a way that is easy to understand and don't try to be clever. Every stored pointer to a ref object should hold its own ref. Jason