Re: [PATCH 1/5] hw/timer/hpet: Include missing 'hw/qdev-properties.h' header

Richard Henderson <richard.henderson@xxxxxxxxxx> · Wed, 15 Feb 2023 08:55:40 -1000

On 2/15/23 07:43, Philippe Mathieu-Daudé wrote:
Avoid when refactoring unrelated headers:

   hw/timer/hpet.c:776:39: error: array has incomplete element type 'Property' (aka 'struct Property')
   static Property hpet_device_properties[] = {
                                         ^
   hw/timer/hpet.c:777:5: error: implicit declaration of function 'DEFINE_PROP_UINT8' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
       DEFINE_PROP_UINT8("timers", HPETState, num_timers, HPET_MIN_TIMERS),
       ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
---
  hw/timer/hpet.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
index 9520471be2..214d6a0501 100644
--- a/hw/timer/hpet.c
+++ b/hw/timer/hpet.c
@@ -30,6 +30,7 @@
  #include "qapi/error.h"
  #include "qemu/error-report.h"
  #include "qemu/timer.h"
+#include "hw/qdev-properties.h"
  #include "hw/timer/hpet.h"
  #include "hw/sysbus.h"
  #include "hw/rtc/mc146818rtc.h"

Acked-by: Richard Henderson <richard.henderson@xxxxxxxxxx>

r~






