On Tue, 14 Feb 2023 15:15:28 +0000 "Liu, Yi L" <yi.l.liu@xxxxxxxxx> wrote: > > From: Jason Gunthorpe <jgg@xxxxxxxxxx> > > Sent: Tuesday, February 14, 2023 7:22 AM > > > > On Mon, Feb 13, 2023 at 12:47:19PM -0700, Alex Williamson wrote: > > > > > I think it's too late for v6.3 already, but given this needs at least > > > one more spin, let's set expectations of this being v6.4 material. Thanks, > > > > Please let's continue to try to get this finished during the merge > > window, all the other series depend on it. We can manage it with a > > shared branch again.. > > > > Sure. I've updated the below branch to address Kevin's latest remarks. > Fixed the compiling failure reported by Alex as well. > > https://github.com/yiliu1765/iommufd/commits/vfio_device_cdev_v3 Sorry, I think this is an abuse of the merge window. We have a new uAPI proposal that's barely a week old and has no reviews or acks other than Yi's, we have build configuration issues which suggests a lack of testing, we're finding subtle implications to other existing uAPIs, and nobody seems to have finished an upstream review, including me. Code for the merge window should already be in maintainer trees by now, the merge window should be for integration. There are a lot of things in flight and many more review comments coming in than we should see for this to be a v6.3 candidate. Thanks, Alex