On Fri, Feb 10, 2023, Yu Zhang wrote: > On Tue, Jan 24, 2023 at 11:49:02PM +0000, Sean Christopherson wrote: > > Move all potential to-be-saved PMU MSRs into a separate array so that a > > future patch can easily omit all PMU MSRs from the list when the PMU is > > disabled. > > > > No functional change intended. > > > > Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx> > > --- > > arch/x86/kvm/x86.c | 153 ++++++++++++++++++++++++--------------------- > > 1 file changed, 82 insertions(+), 71 deletions(-) > > > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index d4a610ffe2b8..9b6e1af63531 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -1419,7 +1419,7 @@ EXPORT_SYMBOL_GPL(kvm_emulate_rdpmc); > > * may depend on host virtualization features rather than host cpu features. > > */ > > > > -static const u32 msrs_to_save_all[] = { > > +static const u32 msrs_to_save_base[] = { > > I guess the comments relating to msr_to_save_all should be updated as well. :) Gah, yes. I caught that at one point but lost track of it. I'll get it fixed in v3. Thanks!