On Mon, Feb 06 2023, Eric Auger <eauger@xxxxxxxxxx> wrote: > Hi, > > On 2/3/23 14:44, Cornelia Huck wrote: >> Acked-by: Thomas Huth <thuth@xxxxxxxxxx> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> >> Signed-off-by: Cornelia Huck <cohuck@xxxxxxxxxx> > > Still as you need to respin I think adding a short commit msg wouldn't > hurt ;-) Add new cpu MTE feature tests with TCG+virt tag memory and > TCG-no tag memory (default) attempting to set cpu mte option on/off. No > real test for KVM because ../.. Ok, I'll add some lines :) >> --- >> tests/qtest/arm-cpu-features.c | 75 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 75 insertions(+) (...) >> +static void mte_tests_default(QTestState *qts, const char *cpu_type) >> +{ >> + assert_has_feature(qts, cpu_type, "mte"); >> + >> + /* >> + * Without tag memory, mte will be off under tcg. >> + * Explicitly enabling it yields an error. >> + */ >> + assert_set_feature_str(qts, "max", "mte", "off", "{ 'mte': 'off' }"); >> + assert_error(qts, cpu_type, "mte=on requires tag memory", >> + "{ 'mte': 'on' }"); > Sorry in v4 I reported I preferred the pauth msg, clarifying now: > > assert_error(qts, cpu_type, "cannot enable pauth-impdef without pauth", > "{ 'pauth': false, 'pauth-impdef': true }"); > > Here would translate into cannot enable mte without tag memory. Oh, so you mean that I should adapt the message generated by the code? [did not get around to the rest of it this week, will try again next week]