On Thu, Feb 09, 2023, Robert Hoo wrote: > On Thu, 2023-02-09 at 14:15 +0800, Chao Gao wrote: > > On Thu, Feb 09, 2023 at 10:40:13AM +0800, Robert Hoo wrote: > > Please add a kvm-unit-test or kselftest for LAM, particularly for > > operations (e.g., canonical check for supervisor pointers, toggle > > CR4.LAM_SUP) which aren't covered by the test in Kirill's series. > > OK, I can explore for kvm-unit-test in separate patch set. Please make tests your top priority. Without tests, I am not going to spend any time reviewing this series, or any other hardware enabling series[*]. I don't expect KVM specific tests for everything, i.e. it's ok to to rely things like running VMs that utilize LAM and/or running LAM selftests in the guest, but I do want a reasonably thorough explanation of how all the test pieces fit together to validate KVM's implementation. [*] https://lore.kernel.org/all/Y+Uq0JOEmmdI0YwA@xxxxxxxxxx
