On Thu, Feb 09, 2023 at 03:23:47AM +0000, Tian, Kevin wrote: > > From: Nicolin Chen <nicolinc@xxxxxxxxxx> > > Sent: Wednesday, February 8, 2023 5:18 AM > > > > Because list_del() is together with iopt_table_remove_domain(), it makes > > sense to have list_add_tail() together with iopt_table_add_domain(). > > > > Also place the mutex outside the iommufd_device_do_attach() call, similar > > to what's in the iommufd_device_auto_get_domain() function. > > > > Co-developed-by: Yi Liu <yi.l.liu@xxxxxxxxx> > > Signed-off-by: Yi Liu <yi.l.liu@xxxxxxxxx> > > Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx> > > Signed-off-by: Nicolin Chen <nicolinc@xxxxxxxxxx> > > shouldn't this be a separate bug fix and backported? double adding a > list item would certainly clobber the list... AFAIK there is no bug, this is just reorganizing things Jason
