On Mon, Feb 6, 2023 at 2:17 PM Ben Gardon <bgardon@xxxxxxxxxx> wrote: > > On Fri, Feb 3, 2023 at 11:28 AM Vipin Sharma <vipinsh@xxxxxxxxxx> wrote: > > - * __tdp_mmu_set_spte - Set a TDP MMU SPTE and handle the associated bookkeeping > > + * _tdp_mmu_set_spte - Set a TDP MMU SPTE and handle the associated bookkeeping > > Nit: Not sure how we got to the point of having a single and double > underscore of the function, but what do you think about just calling > this one tdp_mmu_set_spte and the other tdp_mmu_iter_set_spte? I like your idea. I also don't like the single and double underscore prefix on functions.