On Sun, Feb 05, 2023 at 12:08:49PM -0800, Cong Wang wrote: > On Mon, Jan 30, 2023 at 08:35:11PM -0800, Bobby Eshleman wrote: > > Add support for sockmap to vsock. > > > > We're testing usage of vsock as a way to redirect guest-local UDS requests to > > the host and this patch series greatly improves the performance of such a > > setup. > > > > Compared to copying packets via userspace, this improves throughput by 121% in > > basic testing. > > > > Tested as follows. > > > > Setup: guest unix dgram sender -> guest vsock redirector -> host vsock server > > Threads: 1 > > Payload: 64k > > No sockmap: > > - 76.3 MB/s > > - The guest vsock redirector was > > "socat VSOCK-CONNECT:2:1234 UNIX-RECV:/path/to/sock" > > Using sockmap (this patch): > > - 168.8 MB/s (+121%) > > - The guest redirector was a simple sockmap echo server, > > redirecting unix ingress to vsock 2:1234 egress. > > - Same sender and server programs > > > > *Note: these numbers are from RFC v1 > > > > Only the virtio transport has been tested. The loopback transport was used in > > writing bpf/selftests, but not thoroughly tested otherwise. > > > > This series requires the skb patch. > > > > Looks good to me. Definitely good to go as non-RFC. > > Thanks. Thank you for the review. Best, Bobby
