> From: Tian, Kevin <kevin.tian@xxxxxxxxx> > Sent: Friday, February 3, 2023 12:02 PM > > > From: Alex Williamson <alex.williamson@xxxxxxxxxx> > > Sent: Friday, February 3, 2023 6:01 AM > > > > > > The driver should embed the vfio_device in its own structure and call > > > -vfio_init_group_dev() to pre-configure it before going to registration > > > -and call vfio_uninit_group_dev() after completing the un-registration. > > > +vfio_alloc_device() or _vfio_alloc_device() to allocate the structure, > > > > AIUI, _vfio_alloc_device() is only exported because it's used by > > vfio_alloc_device() which is a macro. I don't think we want to list > > _vfio_alloc_device() as an equal alternative, if anything we should > > discourage any direct use. > > > > Agree Done. Regards, Yi Liu