Re: [RFC PATCH V3 10/16] x86/hyperv: Add smp support for sev-snp guest

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/23/2023 11:30 PM, Tom Lendacky wrote:
On 1/21/23 20:46, Tianyu Lan wrote:
From: Tianyu Lan <tiala@xxxxxxxxxxxxx>

The wakeup_secondary_cpu callback was populated with wakeup_
cpu_via_vmgexit() which doesn't work for Hyper-V. Override it

An explanation as to why is doesn't work would be nice here.

Hi Thomas:
	Thanks for your review. Good idea. Will update.

diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h
index cb1ee53ad3b1..f8b321a11ee4 100644
--- a/arch/x86/include/asm/svm.h
+++ b/arch/x86/include/asm/svm.h
@@ -336,6 +336,53 @@ struct vmcb_save_area {

Please don't update the vmcb_save_area, you should be using/updating the sev_es_save_area structure for SNP.

OK. Will update in the next version.

            u64 sev_feature_restrict_injection    : 1;
+            u64 sev_feature_alternate_injection    : 1;
+            u64 sev_feature_full_debug        : 1;
+            u64 sev_feature_reserved1        : 1;
+            u64 sev_feature_snpbtb_isolation    : 1;
+            u64 sev_feature_resrved2        : 56;

For the bits definition, use:

             u64 sev_feature_snp            : 1,
                 sev_feature_vtom            : 1,
                 sev_feature_reflectvc        : 1,
                 ...


Good suggestion. Thanks.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux