Re: [PATCH 06/39] target/riscv: Add vrol.[vv, vx] and vror.[vv, vx, vi] decoding, translation and execution support

Subject: Re: [PATCH 06/39] target/riscv: Add vrol.[vv, vx] and vror.[vv, vx, vi] decoding, translation and execution support
From: Richard Henderson <richard.henderson@xxxxxxxxxx>
Date: Thu, 2 Feb 2023 13:14:44 -1000
Cc: Lawrence Hunter <lawrence.hunter@xxxxxxxxxxxxxxx>, qemu-devel@xxxxxxxxxx, dickon.hood@xxxxxxxxxxxxxxx, nazar.kazakov@xxxxxxxxxxxxxxx, kiran.ostrolenk@xxxxxxxxxxxxxxx, frank.chang@xxxxxxxxxx, palmer@xxxxxxxxxxx, alistair.francis@xxxxxxx, bin.meng@xxxxxxxxxxxxx, pbonzini@xxxxxxxxxx, kvm@xxxxxxxxxxxxxxx
In-reply-to: <CAAeLtUCTBASoGMMgzp_LxOiFkJq0wJFQUC4kDzCWA47iLR_N5Q@mail.gmail.com>
References: <20230202124230.295997-1-lawrence.hunter@codethink.co.uk> <20230202124230.295997-7-lawrence.hunter@codethink.co.uk> <CAAeLtUA188Tdq4rROAWNqNkMSOXVT0BWQX669L6fyt5oM5knZg@mail.gmail.com> <CAAeLtUDcpyWkKgAo2Lk0ZoHcdyEeVARYkh05Ps27wbOzDF0sHA@mail.gmail.com> <16a6fadf-ca13-d3aa-7e4b-f950db982a21@linaro.org> <CAAeLtUCTBASoGMMgzp_LxOiFkJq0wJFQUC4kDzCWA47iLR_N5Q@mail.gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 2/2/23 08:07, Philipp Tomsich wrote:

      tcg_gen_gvec_rotls(vece, dofs, aofs, tmp, oprsz, maxsz);


We can add rotls generically.
I hadn't done this so far because there were no users.


I read this such that your preference is to have a generic gvec rotrs?
If this is correct, I can drop a patch to that effect…


Yes, please.


r~

References:
- [PATCH 00/39] Add RISC-V vector cryptography extensions
  - From: Lawrence Hunter
- [PATCH 06/39] target/riscv: Add vrol.[vv,vx] and vror.[vv,vx,vi] decoding, translation and execution support
  - From: Lawrence Hunter
- Re: [PATCH 06/39] target/riscv: Add vrol.[vv,vx] and vror.[vv,vx,vi] decoding, translation and execution support
  - From: Philipp Tomsich
- Re: [PATCH 06/39] target/riscv: Add vrol.[vv,vx] and vror.[vv,vx,vi] decoding, translation and execution support
  - From: Philipp Tomsich
- Re: [PATCH 06/39] target/riscv: Add vrol.[vv, vx] and vror.[vv, vx, vi] decoding, translation and execution support
  - From: Richard Henderson
- Re: [PATCH 06/39] target/riscv: Add vrol.[vv, vx] and vror.[vv, vx, vi] decoding, translation and execution support
  - From: Philipp Tomsich