On Thu, Feb 2, 2023 at 12:11 AM Andrew Jones <andrew.jones@xxxxxxxxx> wrote: > > On Thu, Feb 02, 2023 at 10:57:15AM +0800, shahuang@xxxxxxxxxx wrote: > > From: Shaoqin Huang <shahuang@xxxxxxxxxx> > > > > The parameter arg in guest_modes_cmdline not being used now, and the > > optarg should be replaced with arg in guest_modes_cmdline. > > > > And this is the chance to change strtoul() to atoi_non_negative(), since > > guest mode ID will never be negative. > > Fixes: e42ac777d661 ("KVM: selftests: Factor out guest mode code") > > > > > Signed-off-by: Shaoqin Huang <shahuang@xxxxxxxxxx> > > > > --- > > Changes from v1: > > - Change strtoul() to atoi_non_negative(). [Vipin] > > > > --- > > tools/testing/selftests/kvm/lib/guest_modes.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/kvm/lib/guest_modes.c b/tools/testing/selftests/kvm/lib/guest_modes.c > > index 99a575bbbc52..1df3ce4b16fd 100644 > > --- a/tools/testing/selftests/kvm/lib/guest_modes.c > > +++ b/tools/testing/selftests/kvm/lib/guest_modes.c > > @@ -127,7 +127,7 @@ void guest_modes_cmdline(const char *arg) > > mode_selected = true; > > } > > > > - mode = strtoul(optarg, NULL, 10); > > + mode = atoi_non_negative("Guest mode ID", arg); > > TEST_ASSERT(mode < NUM_VM_MODES, "Guest mode ID %d too big", mode); > > guest_modes[mode].enabled = true; > > } > > -- > > 2.39.0 > > > > Reviewed-by: Andrew Jones <andrew.jones@xxxxxxxxx> Reviewed-by: Vipin Sharma <vipinsh@xxxxxxxxxx>