On Thu, 2 Feb 2023 at 15:23, Philipp Tomsich <philipp.tomsich@xxxxxxxx> wrote:
>
> On Thu, 2 Feb 2023 at 13:42, Lawrence Hunter
> <lawrence.hunter@xxxxxxxxxxxxxxx> wrote:
> >
> > From: Nazar Kazakov <nazar.kazakov@xxxxxxxxxxxxxxx>
> >
> > Signed-off-by: Nazar Kazakov <nazar.kazakov@xxxxxxxxxxxxxxx>
>
> You might want to squash this onto the patch that first introduces the property.
>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@xxxxxxxx>
>
> > ---
> > target/riscv/cpu.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> > index bd34119c75..35790befc0 100644
> > --- a/target/riscv/cpu.c
> > +++ b/target/riscv/cpu.c
> > @@ -1082,6 +1082,8 @@ static Property riscv_cpu_extensions[] = {
> >
> > DEFINE_PROP_BOOL("zmmul", RISCVCPU, cfg.ext_zmmul, false),
> >
> > + DEFINE_PROP_BOOL("zvkb", RISCVCPU, cfg.ext_zvkb, false),
I missed this earlier: the extension is not ratified. So please: "x-zvkb".
And it needs to go under the comment:
/* These are experimental so mark with 'x-' */
> > +
> > /* Vendor-specific custom extensions */
> > DEFINE_PROP_BOOL("xventanacondops", RISCVCPU, cfg.ext_XVentanaCondOps, false),
> >
> > --
> > 2.39.1
> >
