Hi Eric, > From: Eric Auger <eric.auger@xxxxxxxxxx> > Sent: Wednesday, January 18, 2023 10:37 PM > > +/** > > + * vfio_file_has_dev - True if the VFIO file is a handle for device > This original description sounds weird because originally it aimed > at figuring whether the device belonged to that vfio group fd, no? > And since it will handle both group fd and device fd it still sounds > weird to me. Yes. It is to check if a device belongs to the input vfio group specified by the group fd. And after this commit, it means if the input file is competent to be handle for the device either due to belong to group or it is just a device fd for the device. I don’t have a better naming so far. How about you? Regards, Yi Liu