On Fri, Nov 11, 2022, Like Xu wrote: > From: Like Xu <likexu@xxxxxxxxxxx> > > The name of function pmc_is_enabled() is a bit misleading. A PMC can > be disabled either by PERF_CLOBAL_CTRL or by its corresponding EVTSEL. > Add the global semantic to its name. > > Suggested-by: Jim Mattson <jmattson@xxxxxxxxxx> > Signed-off-by: Like Xu <likexu@xxxxxxxxxxx> > --- ... > diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c > index 684393c22105..e57f707fb940 100644 > --- a/arch/x86/kvm/pmu.c > +++ b/arch/x86/kvm/pmu.c > @@ -83,7 +83,7 @@ void kvm_pmu_ops_update(const struct kvm_pmu_ops *pmu_ops) > #undef __KVM_X86_PMU_OP > } > > -static inline bool pmc_is_enabled(struct kvm_pmc *pmc) > +static inline bool pmc_is_globally_enabled(struct kvm_pmc *pmc) > { > return static_call(kvm_x86_pmu_pmc_is_enabled)(pmc); This doesn't compile. v3, and I'm getting pings, and the very first patch doesn't compile.