Re: [PATCH 1/3] KVM: selftests: Allocate additional space for latency samples

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sean Christopherson <seanjc@xxxxxxxxxx> writes:

On Tue, Nov 15, 2022, Colton Lewis wrote:
Allocate additional space for latency samples. This has been separated
out to call attention to the additional VM memory allocation.

A blurb in the changelog is sufficient, no need to split allocation and use into two patches. I would actually collapse all three into one. The changes aren't so big that errors will be difficult to bisect, and without the final printing, the other changes are useless for all intents and purposes, i.e. if for some reason we want
to revert the sampling, it will be all or nothing.

Will do. It's easier to merge commits than split them up.


I do think it makes sense to separate the system counter stuff to a separate patch (and land it in generic code), e.g. add helpers to read the system counter
from the guest and convert the result to nanoseconds in a separate
patch.

Will do.



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux