On Tue, Jan 24, 2023 at 08:35:40AM -0800, Ricardo Koller wrote: > On Mon, Jan 23, 2023 at 04:55:40PM -0800, Ben Gardon wrote: [...] > > > +/** > > > + * kvm_pgtable_stage2_free_removed() - Create a removed stage-2 paging structure. > > > + * @pgt: Page-table structure initialised by kvm_pgtable_stage2_init*(). > > > + * @new: Unlinked stage-2 paging structure to be created. > > > > Oh, I see so the "removed" page table is actually a new page table > > that has never been part of the paging structure. In that case I would > > find it much more intuitive to call it "unlinked" or similar. > > > > Sounds good, I like "unlinked". > > Oliver, are you OK if I rename free_removed() as well? just to keep them > symmetric. Fine by me, and sorry for the silly naming :) -- Thanks, Oliver
