Hi, On Sat, Jan 21, 2023 at 12:18:51PM +0000, Marc Zyngier wrote: > On Thu, 19 Jan 2023 18:16:15 +0000, > Will Deacon <will@xxxxxxxxxx> wrote: > > > > On Thu, Jan 19, 2023 at 01:39:32PM +0000, Alexandru Elisei wrote: > > > Hi, > > > > > > CC'ing the kvmtool maintainers and other people that might be interested in this > > > thread. Sorry for hijacking your patch! > > > > > > On Wed, Jan 18, 2023 at 05:20:07PM +0000, Rajnesh Kanwal wrote: > > > > Adding force-pci option to allow forcing virtio > > > > devices to use pci as the default transport. > > > > > > arm is in the same situation, MMIO is the default virtio transport. I was bitten > > > by that in the past. It also cought other people unaware, and I remember maz > > > complaining about it on the list. > > > > > > So I was thinking about adding a new command line parameter, --virtio-transport, > > > with the possible values mmio-legacy, mmio, pci-legacy and pci. Then each > > > architecture can define the default value for the transport. For arm, that would > > > be pci. > > > > > > What do you guys think? > > > > That sounds good to me. Then we can remove --force-pci altogether and maybe > > have PCI as the default for everybody? Should make the tool a little easier > > to use across architectures. > > I'd rather keep --force-pci in order no to break existing scripting. > It just won't do anything once we make PCI the default (which we > definitely should). My plan was to mark --force-pci and --virtio-legacy as deprecated in the help message and to parse them to set the correct value for --virtio-transport (so if --force-pci and --virtio-legacy is specified, the value for --virtio-transport pci-legacy). So as not to break CIs and existing scripts. Since I would be already parsing them, I was wondering if it would be useful to also print a warning on the command line for users to switch to --virtio-transport. Any opinions about this? Thanks, Alex > > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible.
