> From: Tian, Kevin <kevin.tian@xxxxxxxxx>
> Sent: Friday, January 20, 2023 3:02 PM
>
> > From: Liu, Yi L <yi.l.liu@xxxxxxxxx>
> > Sent: Friday, January 20, 2023 1:58 PM
> >
> > struct iommu_option and struct iommu_vfio_ioas are missed in
> ucmd_buffer.
> > Although they are smaller than the size of ucmd_buffer, it is safer to
> > list them in ucmd_buffer explicitly.
> >
> > Fixes: aad37e71d5c4 ("iommufd: IOCTLs for the io_pagetable")
> > Fixes: d624d6652a65 ("iommufd: vfio container FD ioctl compatibility")
> > Signed-off-by: Yi Liu <yi.l.liu@xxxxxxxxx>
> > ---
> > drivers/iommu/iommufd/main.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/iommu/iommufd/main.c
> > b/drivers/iommu/iommufd/main.c
> > index 083e6fcbe10a..1fbfda4b53bf 100644
> > --- a/drivers/iommu/iommufd/main.c
> > +++ b/drivers/iommu/iommufd/main.c
> > @@ -255,6 +255,8 @@ union ucmd_buffer {
> > struct iommu_ioas_iova_ranges iova_ranges;
> > struct iommu_ioas_map map;
> > struct iommu_ioas_unmap unmap;
> > + struct iommu_option option;
> > + struct iommu_vfio_ioas vfio_ioas;
> > #ifdef CONFIG_IOMMUFD_TEST
> > struct iommu_test_cmd test;
> > #endif
>
> while at it can you also add iommu_ioas_copy?
Done in v2.
https://lore.kernel.org/kvm/20230120122040.280219-1-yi.l.liu@xxxxxxxxx/T/#u
Regards,
Yi Liu
