On Thu, Jan 19, 2023 at 03:25:56PM +0800, Yu Zhang wrote: > On Thu, Jan 19, 2023 at 12:53:36AM +0000, Sean Christopherson wrote: > > On Thu, Jan 05, 2023, Yu Zhang wrote: > > > KVM already has a 'GPA_INVALID' defined as (~(gpa_t)0) in kvm_types.h, > > > and it is used by ARM code. We do not need another definition of > > > 'INVALID_GPA' for X86 specifically. > > > > > > Instead of using the common 'GPA_INVALID' for X86, replace it with > > > 'INVALID_GPA', and change the users of 'GPA_INVALID' so that the diff > > > can be smaller. Also because the name 'INVALID_GPA' tells the user we > > > are using an invalid GPA, while the name 'GPA_INVALID' is emphasizing > > > the GPA is an invalid one. > > > > > > No functional change intended. > > > > > > Signed-off-by: Yu Zhang <yu.c.zhang@xxxxxxxxxxxxxxx> > > > Reviewed-by: Paul Durrant <paul@xxxxxxx> > > > Reviewed-by: Sean Christopherson <seanjc@xxxxxxxxxx> > > > --- > > > > Marc and/or Oliver, > > > > Do you want to grab this since most of the changes are to arm64? I'll happily > > take it through x86, but generating a conflict in arm64 seems infinitely more likely. > > > Thank you, Sean! > > This patch was based on KVM's next branch - fc471e831016c ("Merge branch 'kvm-late-6.1' > into HEAD"). Tested by cross-building arm64. > > Do you know if KVM arm use a seperate branch(or repo)? Thanks! Yes, you can find us over here: https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git/ I'll grab this after I wrap up testing what I have so far. -- Thanks, Oliver