On Thu, Jan 19, 2023, Paolo Bonzini wrote:
> On Thu, Jan 19, 2023 at 6:57 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
> > > This change generates a build failure with error message:
> > > "error: a label can only be part of a statement and a declaration is not a statement".
> >
> > And other flavors too, e.g.
> >
> > x86_64/xen_shinfo_test.c:965:2: error: expected expression
> > struct kvm_xen_hvm_attr evt_reset = {
> > ^
> > x86_64/xen_shinfo_test.c:969:38: error: use of undeclared identifier 'evt_reset'
> > vm_ioctl(vm, KVM_XEN_HVM_SET_ATTR, &evt_reset);
> > ^
> > x86_64/xen_shinfo_test.c:969:38: error: use of undeclared identifier 'evt_reset'
> > 3 errors generated.
> > make: *** [../lib.mk:145: tools/testing/selftests/kvm/x86_64/xen_shinfo_test] Error 1
> > make: *** Waiting for unfinished jobs....
> >
> > I'm surprised bots haven't complained about this, haven't seen any reports.
>
> It's clang only; GCC only warns with -Wpedantic. Plus, bots probably
> don't compile tools/ that much.
/wave
Want to queue Yu's fix directly Paolo? I was assuming you'd be offline until
sometime tomorrow.
