On 1/11/2023 8:50 AM, Sabin Rapan wrote:
On 14.12.2022 21:40, Michael Roth wrote:
+#ifdef CONFIG_AMD_MEM_ENCRYPT
+# define DISABLE_SEV_SNP 0
+#else
+# define DISABLE_SEV_SNP (1 << (X86_FEATURE_SEV_SNP & 31))
+#endif
+
Would it make sense to split the SEV-* feature family into their own
config flag(s) ?
I'm thinking in the context of SEV-SNP running on systems with
Transparent SME enabled in the bios. In this case, enabling
CONFIG_AMD_MEM_ENCRYPT will also enable SME in the kernel, which is a
bit strange and not necessarily useful.
Commit 4e2c87949f2b ("crypto: ccp - When TSME and SME both detected
notify user") highlights it.
Yes, we plan to move the SNP host initialization stuff into a separate
source file and under a different config flag such as CONFIG_KVM_AMD_SEV
or something.
Thanks,
Ashish
