On Wed, Jan 18, 2023, Alexandru Matei wrote: > On 1/18/2023 6:25 PM, Vitaly Kuznetsov wrote: > > Oh, indeed, I've forgotten this. I'm fine with 'vmx->vmcs01' then but > > let's leave a comment (which I've going to also forget about, but still) > > that eMSR bitmap is an L1-only feature. > > > >> > >> 3. KVM's manipulation of MSR bitmaps typically happens _only_ for vmcs01, > >> e.g. the caller is vmx_msr_bitmap_l01_changed(). The nested case is a > >> special snowflake. > >> > > > > Thanks Sean and Vitaly for your insights and suggestions. I'll redo the patch > using your code Sean if it's ok with you and run the tests again. Yep, absolutely! As requested by Vitlay, please also add a comment in evmcs_touch_msr_bitmap() to call out that the eMSR bitmap is only enabled for L1, i.e. always operates on (e)vmcs01. Thanks!
